[webkit-reviews] review granted: [Bug 67825] Implement a WebKitAnimationEvent constructor for JSC : [Attachment 106825] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 8 18:50:33 PDT 2011

Sam Weinig <sam at webkit.org> has granted Kentaro Hara <haraken at google.com>'s
request for review:
Bug 67825: Implement a WebKitAnimationEvent constructor for JSC

Attachment 106825: Patch

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106825&action=review

> Source/WebCore/ChangeLog:17
> +	   [Constructor(DOMString type, optional WebKitAnimationEventInit
> +	   dictionary WebKitAnimationEventInit : EventInit {
> +	       DOMString animationName;
> +	       double elapsedTime;
> +	   }

This is not what the IDL would look like.  The constructor would be on the
Event itself, not the Init.

More information about the webkit-reviews mailing list