[webkit-reviews] review requested: [Bug 67337] Update RegExp and related classes to use 8 bit strings when available : [Attachment 106826] Updated patch addressing the concerns raised with the prior patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 8 18:43:40 PDT 2011
Michael Saboff <msaboff at apple.com> has asked for review:
Bug 67337: Update RegExp and related classes to use 8 bit strings when
available
https://bugs.webkit.org/show_bug.cgi?id=67337
Attachment 106826: Updated patch addressing the concerns raised with the prior
patch.
https://bugs.webkit.org/attachment.cgi?id=106826&action=review
------- Additional Comments from Michael Saboff <msaboff at apple.com>
I checked the performance of the interpreter character size check with JIT
turned off running V8 RegExp test. It is 3% slower. As we change to use the
replacement class we can check and tune at that time.
There still may be an export issue with windows that I will rely on the
buildbot catching.
More information about the webkit-reviews
mailing list