[webkit-reviews] review granted: [Bug 66323] Rename FontGtk.cpp to FontPango.cpp : [Attachment 106503] Move FontGtk.cpp to FontPango.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 8 16:08:27 PDT 2011


Martin Robinson <mrobinson at webkit.org> has granted Rafael Antognolli
<antognolli at profusion.mobi>'s request for review:
Bug 66323: Rename FontGtk.cpp to FontPango.cpp
https://bugs.webkit.org/show_bug.cgi?id=66323

Attachment 106503: Move FontGtk.cpp to FontPango.cpp
https://bugs.webkit.org/attachment.cgi?id=106503&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106503&action=review


> Source/WebCore/ChangeLog:29
> +	   (WebCore::destroyPangoRegion):
> +	   (WebCore::getPangoRegionExtents):
> +	   (WebCore::utf16ToUtf8):
> +	   (WebCore::convertUniCharToUTF8):
> +	   (WebCore::setPangoAttributes):
> +	   (WebCore::Font::canReturnFallbackFontsForComplexText):
> +	   (WebCore::Font::canExpandAroundIdeographsInComplexText):
> +	   (WebCore::drawGlyphsShadow):
> +	   (WebCore::Font::drawComplexText):
> +	   (WebCore::Font::drawEmphasisMarksForComplexText):
> +	   (WebCore::getDefaultPangoLayout):
> +	   (WebCore::Font::floatWidthForComplexText):
> +	   (WebCore::Font::offsetForPositionForComplexText):
> +	   (WebCore::Font::selectionRectForComplexText):
> +

You can just remove these lines, since you aren't filling them in.


More information about the webkit-reviews mailing list