[webkit-reviews] review granted: [Bug 67127] Web Inspector: Implement circular tabbing through the Styles sidebar pane contents : [Attachment 106581] [PATCH] A minimally intrusive solution

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 67127: Web Inspector: Implement circular tabbing through the Styles sidebar
pane contents
https://bugs.webkit.org/show_bug.cgi?id=67127

Attachment 106581: [PATCH] A minimally intrusive solution
https://bugs.webkit.org/attachment.cgi?id=106581&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106581&action=review


> Source/WebCore/inspector/front-end/StylesSidebarPane.js:944
> +		   if (curSection === this)

This shouldn't be needed since there is no sibling after the last section.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:950
> +	   return curSection.editable ? curSection : null;

return (curSection && curSection.editable) ? curSection : null;

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:966
> +		   curSection = curSection.previousSibling;

Ditto.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:970
> +	   return curSection.editable ? curSection : null;

Ditto.