[webkit-reviews] review denied: [Bug 67192] API to set initial focus in gtk webkit : [Attachment 106552] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Antaryami Pandia
<xqb748 at motorola.com>'s request for review:
Bug 67192: API to set initial focus in gtk webkit
https://bugs.webkit.org/show_bug.cgi?id=67192

Attachment 106552: Patch
https://bugs.webkit.org/attachment.cgi?id=106552&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106552&action=review


> Source/WebKit/gtk/tests/testwebview.c:390
> +
> +    gtk_widget_show_all(window);
> +    g_signal_connect(window, "map-event",
> +			G_CALLBACK(map_event_cb), loop);
> +    g_main_loop_run(loop);
> +
> +    webkit_web_view_load_uri(view, uri);
> +    g_main_loop_run(loop);
> +
> +    webkit_web_view_set_initial_focus(view, true);
> +    g_main_loop_run(loop);
> +
> +    g_free(uri);
> +    gtk_widget_destroy(window);

Your test has no assertions!

> Source/WebKit/gtk/webkit/webkitwebview.cpp:4031
> + * Set the initial focus element.

Even with this documentation, I'm still not sure what this API does or how it
works. I think this could be exanded greatly here. Does GTK+ even have the
concept of focus direction? What situations is this API useful?