[webkit-reviews] review requested: [Bug 67590] Implement DRT support for Android. : [Attachment 106550] Proposed patch 5.

[bugzilla-daemon at webkit.org]

Hao Zheng <zhenghao at chromium.org> has asked  for review:
Bug 67590: Implement DRT support for Android.
https://bugs.webkit.org/show_bug.cgi?id=67590

Attachment 106550: Proposed patch 5.
https://bugs.webkit.org/attachment.cgi?id=106550&action=review

------- Additional Comments from Hao Zheng <zhenghao at chromium.org>
> > 
> > > Tools/DumpRenderTree/chromium/TestShellGtk.cpp:-188
> > > -    signal(SIGALRM, SIG_DFL);
> > 
> > Why don't we need to reset the previous handler?
> 
> alarmAction.sa_flags = SA_RESETHAND;
> This will reset the handler.

Sorry, I'm wrong at this point. SA_RESETHAND will only reset handler when the
signal is received. Seems we only need to install the handler once for DRT, and
no need to install&reset handler for every test. But I still keep it the old
way here.