[webkit-reviews] review canceled: [Bug 67590] Implement DRT support for Android. : [Attachment 106403] Proposed patch 4.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 7 00:10:42 PDT 2011

Hao Zheng <zhenghao at chromium.org> has canceled Hao Zheng
<zhenghao at chromium.org>'s request for review:
Bug 67590: Implement DRT support for Android.

Attachment 106403: Proposed patch 4.

------- Additional Comments from Hao Zheng <zhenghao at chromium.org>
> > 
> > > Tools/DumpRenderTree/chromium/TestShellGtk.cpp:-188
> > > -    signal(SIGALRM, SIG_DFL);
> > 
> > Why don't we need to reset the previous handler?
> alarmAction.sa_flags = SA_RESETHAND;
> This will reset the handler.

Sorry, I'm wrong at this point. SA_RESETHAND will only reset handler when the
signal is received. Seems we only need to install the handler once for DRT, and
no need to install&reset handler for every test. But I still keep it the old
way here.

More information about the webkit-reviews mailing list