[webkit-reviews] review granted: [Bug 67573] [Chromium] Add WebFloatQuad.h for Android : [Attachment 106348] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 6 13:42:20 PDT 2011

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 67573: [Chromium] Add WebFloatQuad.h for Android

Attachment 106348: Patch

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106348&action=review

> Source/WebKit/chromium/public/WebFloatQuad.h:37
> +#include <algorithm>

nit: shouldn't system includes be listed first?

> Source/WebKit/chromium/public/WebFloatQuad.h:79
> +}

nit: } // namespace WebKit

see part 3 of the webkit style guide

More information about the webkit-reviews mailing list