[webkit-reviews] review granted: [Bug 66800] [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent : [Attachment 106462] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 6 13:37:38 PDT 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 66800: [Chromium] Modify WebTouchEvent structure to match
WebCore::TouchEvent
https://bugs.webkit.org/show_bug.cgi?id=66800

Attachment 106462: Patch
https://bugs.webkit.org/attachment.cgi?id=106462&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106462&action=review


> Source/WebKit/chromium/src/WebInputEventConversion.cpp:53
> +static const double kMillisPerSecond = 1000.0;

nit: I don't think WebKit uses the k* prefix for constants.  this should just
be millisPerSecond.

> Source/WebKit/chromium/src/WebInputEventConversion.cpp:385
> +    unsigned numberOfCharacters =
std::min(event.keyEvent()->text().length(),
static_cast<unsigned>(WebKeyboardEvent::textLengthCap));

note: since WebKeyboardEventBuilder extends from WebKeyboardEvent, no need for
the WebKeyboardEvent:: prefix in front of textLengthCap.


More information about the webkit-reviews mailing list