[webkit-reviews] review granted: [Bug 67610] Web Inspector: disable popover when a mouse button is pressed : [Attachment 106409] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 67610: Web Inspector: disable popover when a mouse button is pressed
https://bugs.webkit.org/show_bug.cgi?id=67610

Attachment 106409: patch
https://bugs.webkit.org/attachment.cgi?id=106409&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106409&action=review


Looks good with a couple of nits.

> Source/WebCore/inspector/front-end/SourceFrame.js:724
> +	   if (!this._textViewer.readOnly) {

Do you need this? Will this method be called in case editing starts?

> Source/WebCore/inspector/front-end/SourceFrame.js:827
> +	   if (this._popoverHelper)

This should probably go into _setReadOnly.