[webkit-reviews] review denied: [Bug 67506] Web Inspector: [Extensions API] expose console API : [Attachment 106326] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 67506: Web Inspector: [Extensions API] expose console API
https://bugs.webkit.org/show_bug.cgi?id=67506

Attachment 106326: patch
https://bugs.webkit.org/attachment.cgi?id=106326&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106326&action=review


> LayoutTests/inspector/extensions/extensions-api-expected.txt:86
> +	   MessageSeverity : {

I'd do simply Severity. It is in either case under console.

> Source/WebCore/inspector/front-end/ExtensionServer.js:-429
> -	   // The networkManager is normally created after the ExtensionServer
is constructed, but before initExtensions() is called.

This is going against the performance effort we are currently focusing on.
Specifically, this will do something upon every console message no matter
whether there are extensions interested in this type of event. Probably need to
resolve it for all the notifications below. r- for that.