[webkit-reviews] review denied: [Bug 67506] Web Inspector: [Extensions API] expose console API : [Attachment 106157] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Sep 4 23:00:17 PDT 2011
Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 67506: Web Inspector: [Extensions API] expose console API
https://bugs.webkit.org/show_bug.cgi?id=67506
Attachment 106157: patch
https://bugs.webkit.org/attachment.cgi?id=106157&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106157&action=review
Lets first agree on what is the console message for formatted console records
and evaluation results. Otherwise looks good.
> LayoutTests/inspector/extensions/extensions-api-expected.txt:86
> + MessageLevel : {
Severity ?
> Source/WebCore/inspector/front-end/ConsoleMessage.js:449
> + return this._messageText;
Real text is formatted asynchronously, what text do you expect to return for
console.log("Foo %s", document) ?
> Source/WebCore/inspector/front-end/ConsoleMessage.js:454
> + return this._parameters;
Parameters are object wrappers that are not exposed to the user.
More information about the webkit-reviews
mailing list