[webkit-reviews] review denied: [Bug 67483] Web Inspector: Console is always scrolled to the top : [Attachment 106166] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 67483: Web Inspector: Console is always scrolled to the top
https://bugs.webkit.org/show_bug.cgi?id=67483

Attachment 106166: Patch
https://bugs.webkit.org/attachment.cgi?id=106166&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106166&action=review


> Source/WebCore/inspector/front-end/ConsoleView.js:227
> +	   WebInspector.View.prototype.show.call(this);

I remember caseq implementing View hierarchy that was moving the logic from
show and hide to wasShown and willHide. Is this change in line with what he was
doing?

> Source/WebCore/inspector/front-end/ConsoleView.js:254
> +	   if (this._scrolledToBottom)

You might want to just override the original logic here so that you don't use
this hybrid approach.

> Source/WebCore/inspector/front-end/ConsoleView.js:262
> +	   this.restoreScrollPositions();

this._scrolledToBottom value might be out of date by this moment (user scrolled
manually).