[webkit-reviews] review granted: [Bug 67549] [chromium] Check in 'build' for compiled binaries first : [Attachment 106237] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 67549: [chromium] Check in 'build' for compiled binaries first
https://bugs.webkit.org/show_bug.cgi?id=67549

Attachment 106237: Patch
https://bugs.webkit.org/attachment.cgi?id=106237&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
The change looks fine to me so I'm R+'ing it. I'm on the fence as to whether
writing tests for this is particularly valuable, but if you did want to, the
way I'd do it would be to add some tests to chromium_win_unittest that created
a port, overrode the port._filesystem field to a dummy object that implemented
exists() for various paths, and then called port.build_path to exercise various
branches.