[webkit-reviews] review denied: [Bug 38054] [Qt] Build dependency problems : [Attachment 105925] proposed fix

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at nokia.com> has denied Kristóf Kosztyó
<kkristof at inf.u-szeged.hu>'s request for review:
Bug 38054: [Qt] Build dependency problems
https://bugs.webkit.org/show_bug.cgi?id=38054

Attachment 105925: proposed fix
https://bugs.webkit.org/attachment.cgi?id=105925&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>
Looks like this should fix it, simple and efficient!
One thing that should be changed is to move the CONFIG(compute_defaults) { }
part in Source/WebCore/features.pri to the end of the file and a comment should
be added to say that nothing should be placed after it.

For example right now, since ENABLE_XHTMLMP is defined after the
compute_defaults part, changing it won't trigger a clean build. Beside this it
LGTM.