[webkit-reviews] review denied: [Bug 64297] [Qt][WK2] Add the Web Inspector to WebKit2 : [Attachment 105850] Patch to add Web Inspector to WebKit2 updated.

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Genisim
<genisim at yahoo.com>'s request for review:
Bug 64297: [Qt][WK2] Add the Web Inspector to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=64297

Attachment 105850: Patch to add Web Inspector to WebKit2 updated.
https://bugs.webkit.org/attachment.cgi?id=105850&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105850&action=review


How can a patch go through so many iterations and still so so wrong?

> Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h:53
> +namespace WebKit {
> +    class WebInspectorProxy;
> +}

We don't indent in namespaces.

> Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h:74
> +    void setDeveloperExtrasEnabled(bool);
> +    void setWebInspectorEnabled(bool);

We don't have settings on the QDesktopWebView.	That is just plain wrong.

> Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp:743
> +void QtWebPageProxy::setDeveloperExtrasEnabled(bool enable)
> +{
> +   
m_webPageProxy->pageGroup()->preferences()->setDeveloperExtrasEnabled(enable);
> +}

This totally doesn't belong here