[webkit-reviews] review requested: [Bug 70860] [MutationObservers] Support attributeFilter for attribute mutations : [Attachment 113083] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 31 13:56:05 PDT 2011


Rafael Weinstein <rafaelw at chromium.org> has asked  for review:
Bug 70860: [MutationObservers] Support attributeFilter for attribute mutations
https://bugs.webkit.org/show_bug.cgi?id=70860

Attachment 113083: Patch
https://bugs.webkit.org/attachment.cgi?id=113083&action=review

------- Additional Comments from Rafael Weinstein <rafaelw at chromium.org>
This is now ready for review. Note that there is a FIXME in webkit mutation
observer pointing out that the addition of the attributeFilter in
MutationObserverRegistration means that transient subtree observation now does
more copying than necessary.

As noted in Adam's characterDataOldValue change, we are waiting until both
patches are landed and then will cleanup a number of things with a refactor
which will split out MutationObserverRegistration into it's own class which
doesn't get copied around


More information about the webkit-reviews mailing list