[webkit-reviews] review granted: [Bug 71234] webkitpy tests depend to much on the user's environment : [Attachment 113080] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 71234: webkitpy tests depend to much on the user's environment
https://bugs.webkit.org/show_bug.cgi?id=71234

Attachment 113080: Patch
https://bugs.webkit.org/attachment.cgi?id=113080&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113080&action=review


change looks basically good, with a few nits.

> Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:187
> +	   # FIXME: Note we do not pass a filesystem as the "test port"
magically suplies its own mock filesystem.

Why add the FIXME here?

> Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py:116
> +	   port = self.make_port(executive=executive)

The whole point of this test is that we're actually testing the implementation
of wdiff, so we have to use a real executive. This should be renamed to
integration_test_run_wdiff() instead (I think this test predates the concept of
integration tests).