[webkit-reviews] review denied: [Bug 58417] SVG object covers CSS background in HTML foreignObject : [Attachment 113057] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Florin Malita
<fmalita at google.com>'s request for review:
Bug 58417: SVG object covers CSS background in HTML foreignObject
https://bugs.webkit.org/show_bug.cgi?id=58417

Attachment 113057: Patch
https://bugs.webkit.org/attachment.cgi?id=113057&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113057&action=review


Looks good to me on first sight, but r- as it duplicates code.
I wonder about the possible implications/side-effects though. I'd prefer if
Dave/Simon/Dan could have a look! I'd want to hear their comments too.

> Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp:66
> +    // Paint all phases of FO elements atomically, as though the FO element
established its
> +    // own stacking context.

Can't you share this code between InlineBox and RenderSVGFO in a common base?
Replicating this is not a good idea.