[webkit-reviews] review granted: [Bug 71223] CSSRule: Devirtualize insertedIntoParent() : [Attachment 113055] Probably a patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 71223: CSSRule: Devirtualize insertedIntoParent()
https://bugs.webkit.org/show_bug.cgi?id=71223

Attachment 113055: Probably a patch
https://bugs.webkit.org/attachment.cgi?id=113055&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=113055&action=review


r=me, with a comment.

> Source/WebCore/css/CSSImportRule.cpp:112
> -void CSSImportRule::insertedIntoParent()
> +void CSSImportRule::insertedIntoStyleSheet()

Maybe a name that describes what it actually does? Something like
"requestStyleSheet".

Or perharps the loading code should actually live in CSSStyleSheet?