[webkit-reviews] review granted: [Bug 71218] Kill StyleBase. : [Attachment 113044] Le Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 71218: Kill StyleBase.
https://bugs.webkit.org/show_bug.cgi?id=71218

Attachment 113044: Le Patch
https://bugs.webkit.org/attachment.cgi?id=113044&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=113044&action=review


r=me, very nice!

> Source/WebCore/css/CSSStyleSheet.cpp:254
> +    for (CSSStyleSheet* sheet = this; sheet; sheet =
sheet->parentStyleSheet()) {
> +	   if (Node* ownerNode = sheet->ownerNode())
> +	       return ownerNode->document();

Wonder if the ownerNode is always found from the root. If so, this could be a
root search + assertion that ownerNode is null in child stylesheets.