[webkit-reviews] review granted: [Bug 71007] [Microdata] Support for itemid attribute. : [Attachment 112697] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 31 06:47:55 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has granted Arko Saha <nghq36 at motorola.com>'s
request for review:
Bug 71007: [Microdata] Support for itemid attribute.
https://bugs.webkit.org/show_bug.cgi?id=71007

Attachment 112697: Updated patch
https://bugs.webkit.org/attachment.cgi?id=112697&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112697&action=review


> LayoutTests/fast/dom/MicroData/itemid-attribute-test-expected.txt:18
> +PASS createElement('div', {itemid: ' http://example.com/foo '}).itemId ==
'http://example.com/foo'; is true

You should test leading whitespace as well.


More information about the webkit-reviews mailing list