[webkit-reviews] review granted: [Bug 71132] IndexedDB: Remove null key support (part 2) : [Attachment 112896] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 30 22:57:19 PDT 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Joshua Bell
<jsbell at chromium.org>'s request for review:
Bug 71132: IndexedDB: Remove null key support (part 2)
https://bugs.webkit.org/show_bug.cgi?id=71132

Attachment 112896: Patch
https://bugs.webkit.org/attachment.cgi?id=112896&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112896&action=review


OK, R=me.  Will

> Source/WebKit/chromium/ChangeLog:8
> +	   Part 2 of a two-sided commit. Remove IDBKey::NullType now that

nit: this kind of detail about the mechanics of landing this patch probably
don't need to be in the ChangeLog.  i would just type this as a comment in the
bug.


More information about the webkit-reviews mailing list