[webkit-reviews] review denied: [Bug 70556] [Chromium] Plumb DPI info into PlatformScreen : [Attachment 112880] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Fady Samuel
<fsamuel at chromium.org>'s request for review:
Bug 70556: [Chromium] Plumb DPI info into PlatformScreen
https://bugs.webkit.org/show_bug.cgi?id=70556

Attachment 112880: Patch
https://bugs.webkit.org/attachment.cgi?id=112880&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112880&action=review


What about the other factories?  Mac and Windows?

> Source/WebCore/platform/PlatformScreen.h:50
> +    int screenDpi(Widget*);

I think you should write "DPI" (see webkit style guide).

> Source/WebKit/chromium/public/WebScreenInfo.h:39
> +    // The screen (width) dpi.

when you say "width" here, do you mean horizontal?