[webkit-reviews] review granted: [Bug 71032] REGRESSION(r98542): tables/mozilla_expected_failures/bugs/bug14007-2.html : [Attachment 112863] better, more explicit test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 28 09:28:09 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 71032: REGRESSION(r98542):
tables/mozilla_expected_failures/bugs/bug14007-2.html
https://bugs.webkit.org/show_bug.cgi?id=71032

Attachment 112863: better, more explicit test
https://bugs.webkit.org/attachment.cgi?id=112863&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112863&action=review


> LayoutTests/fast/css/inherited-properties-explicit.html:36
> +These should be 0px, 0px, 5px, 5px, 10px, 10px:

Instead of stating expectations here

> LayoutTests/fast/css/inherited-properties-explicit.html:49
> +test('test1a', 'margin-left');
> +test('test1b', 'margin-left');
> +test('test2a', 'margin-left');
> +test('test2b', 'margin-left');
> +test('test3a', 'margin-left');
> +test('test3b', 'margin-left');

Can we just call shouldBe here? (i.e. turn this into a script test.


More information about the webkit-reviews mailing list