[webkit-reviews] review granted: [Bug 71109] [GTK] Add methods to get/set the settings of a web view to WebKit2 GTK+ API : [Attachment 112848] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 71109: [GTK] Add methods to get/set the settings of a web view to WebKit2
GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=71109

Attachment 112848: Patch
https://bugs.webkit.org/attachment.cgi?id=112848&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112848&action=review


> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:617
> + * Sets the #WebKitSettings to be applied to @web_view. The
> + * existing #WebKitSettings of @web_view will be replaced by
> + * @settings. The same #WebKitSettings object can be shared
> + * by multiple #WebKitWebView<!-- -->s.

Might want to note that the settings on the WebView are updated immediately.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:638
> + * #WebKitSettings will be returned. This method always return

return -> returns

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:645
> + * @web_view settings and update it directly. Take into account that
> + * #WebKitSettings objects can be shared by multiple

I'd just remove "Take into account that" here.

> Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp:70
> +    GRefPtr<GtkWidget> webView2 = webkit_web_view_new();
> +    test->assertObjectIsDeletedWhenTestFinishes(G_OBJECT(webView2.get()));
> +    webkit_web_view_set_settings(WEBKIT_WEB_VIEW(webView2.get()), settings);

> +    g_assert(webkit_web_view_get_settings(WEBKIT_WEB_VIEW(webView2.get()))
== settings);
> +

Might want to add an assertion here that the default settings object on
webView2 is different than the one from test->m_webView.