[webkit-reviews] review denied: [Bug 71023] [chromium] Paint directly to shared memory buffers : [Attachment 112706] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied David Reveman
<reveman at chromium.org>'s request for review:
Bug 71023: [chromium] Paint directly to shared memory buffers
https://bugs.webkit.org/show_bug.cgi?id=71023

Attachment 112706: Patch
https://bugs.webkit.org/attachment.cgi?id=112706&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112706&action=review


> Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp:401
> +	   // Blocking call to CCThreadProxy::allocateOnImplThread
> +	   TRACE_EVENT("allocate", this, 0);
> +	   CCCompletionEvent completion;
> +	   s_ccThread->postTask(createCCThreadTask(this,
&CCThreadProxy::allocateOnImplThread, AllowCrossThreadAccess(&completion)));
> +	   completion.wait();

woah what? This is not right at all!