[webkit-reviews] review denied: [Bug 70951] IDL constants can't use [Reflect] : [Attachment 112698] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Anna Cavender <annacc at chromium.org>'s
request for review:
Bug 70951: IDL constants can't use [Reflect]
https://bugs.webkit.org/show_bug.cgi?id=70951

Attachment 112698: Patch
https://bugs.webkit.org/attachment.cgi?id=112698&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112698&action=review


Do we need this feature to work for JSC as well?

> Source/WebCore/bindings/scripts/test/TestObj.idl:193
> +	   const [Reflect=CONST_CUSTOM] unsigned short CONST_REFLECTED = 0;

I would have used a number other than zero here, just because 0 is a special
number that could come from lots of places.  You want to make sure this number
makes it to the output file.

> Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp:1386
> +    {"CONST_CUSTOM", static_cast<signed int>(0)},

It looks like you've got this backwards, right?  Reading this code CONST_CUSTOM
is exposed to JavaScript, but TestObj::CONST_REFLECTED is used on the
implementation object.	I would have expected the reverse.