[webkit-reviews] review granted: [Bug 70741] Remove getOwnPropertySlotVirtual : [Attachment 112404] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 26 09:47:13 PDT 2011


Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 70741: Remove getOwnPropertySlotVirtual
https://bugs.webkit.org/show_bug.cgi?id=70741

Attachment 112404: Patch
https://bugs.webkit.org/attachment.cgi?id=112404&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=112404&action=review


r=me

> Source/JavaScriptCore/API/JSCallbackObject.h:178
> +    const MethodTable* methodTable() const
> +    {
> +	   return Parent::methodTable();
> +    }

I believe "using Parent::methodTable;" would work here, and be slightly more
precise about what you mean.


More information about the webkit-reviews mailing list