[webkit-reviews] review denied: [Bug 69022] Get rid of EditingText : [Attachment 111911] Updated Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 21 06:35:27 PDT 2011


Chang Shu <cshu at webkit.org> has denied Kaustubh Atrawalkar
<kaustubh at motorola.com>'s request for review:
Bug 69022: Get rid of EditingText
https://bugs.webkit.org/show_bug.cgi?id=69022

Attachment 111911: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=111911&action=review

------- Additional Comments from Chang Shu <cshu at webkit.org>
I have to r- this patch since it breaks the test case. Btw, the test case
[['a'], false, true, true] means you enter 'a' and you expects 'a' remains the
same and after a delay it changes to '*'. The last 'true' simply tells the test
engine to check the expectations before running to the 2nd line. While in
password-echo-passnode2.html, you don't check result for 1st line, i.e., you
type two characters without a delay in between. I suggest you put some
breakpoints in my original patch to debug this.


More information about the webkit-reviews mailing list