[webkit-reviews] review canceled: [Bug 69343] [GTK] Initial implementation of back forward list for WebKit2 GTK+ API : [Attachment 111759] Patch updated to current git master

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has canceled Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 69343: [GTK] Initial implementation of back forward list for WebKit2 GTK+
API
https://bugs.webkit.org/show_bug.cgi?id=69343

Attachment 111759: Patch updated to current git master
https://bugs.webkit.org/attachment.cgi?id=111759&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
Another update addressing all review comments, except returning empty strings,
I still think we should return NULL instead, for the following reasons:

 - It's a common pattern in GNOME platform, so we should be consistent with our
platform
 - For this reason, this is what our users expect, look at this ephy commit for
example: 
  
http://git.gnome.org/browse/epiphany/commit/?id=9ea9e684b4cb5563d5b395a93b92377
1b0f6bffc
   Even though wk1 returns empty strings, both new and old code in that patch
checks for NULL, not to for ""
 - Mac API returns NULL too (well, nil): see
http://trac.webkit.org/browser/trunk/Source/WebKit/mac/History/WebHistoryItem.m
m#L167
 - It avoids unnecessary allocation and string comparison