[webkit-reviews] review granted: [Bug 69823] [GTK] Add can_go_back/forward methods to WebKit2 GTK+ API : [Attachment 110486] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 20 22:57:47 PDT 2011


Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 69823: [GTK] Add can_go_back/forward methods to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69823

Attachment 110486: Patch
https://bugs.webkit.org/attachment.cgi?id=110486&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110486&action=review


This looks good to me!

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:303
> + * Returns: %TRUE if able to move back, %FALSE otherwise.

, -> or

(based on our previous conversation)

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:333
> + * Returns: %TRUE if able to move forward, %FALSE otherwise.

Ditto.


More information about the webkit-reviews mailing list