[webkit-reviews] review granted: [Bug 69610] [GTK] Add webkit_web_view_stop_loading() to WebKit2 GTK+ API : [Attachment 111418] Updated patch according to review comments

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 69610: [GTK] Add webkit_web_view_stop_loading() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69610

Attachment 111418: Updated patch according to review comments
https://bugs.webkit.org/attachment.cgi?id=111418&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111418&action=review


Great.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:293
> + * If there is a loading operation in progress, it will be cancelled and
> + * #WebKitWebLoaderClient::provisional-load-failed or
> + * #WebKitWebLoaderClient::load-failed will be emitted on the current
> + * #WebKitWebLoaderClient with %WEBKIT_NETWORK_ERROR_CANCELLED error.
> + * See also webkit_web_view_get_loader_client().

This doc is awesome.