[webkit-reviews] review granted: [Bug 70535] WK2 - Crash deref'ing a null context menu : [Attachment 111826] Patch v1 - s/assert/early return/

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 70535: WK2 - Crash deref'ing a null context menu
https://bugs.webkit.org/show_bug.cgi?id=70535

Attachment 111826: Patch v1 - s/assert/early return/
https://bugs.webkit.org/attachment.cgi?id=111826&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=111826&action=review


> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2076
> -    ASSERT(m_contextMenu);
> +    if (!m_contextMenu)
> +	   return;

If we don’t know why it happens and hope to some day track it down, then we
could augment the assert with a return rather than replacing it with a return.

But if we think it’s not surprising since the back and forth is cross-process
without a strong guarantee the processes are in-sync, then perhaps we should
land this patch as-is.

Also, if there is some kind of race her then maybe each context menu needs an
ID so choosing an item from an old context menu doesn’t get mixed up with a new
one.