[webkit-reviews] review requested: [Bug 69986] Web Inspector: Make indent configurable : [Attachment 111827] Another attempt

[bugzilla-daemon at webkit.org]

Nikita Vasilyev <me at elv1s.ru> has asked  for review:
Bug 69986: Web Inspector: Make indent configurable
https://bugs.webkit.org/show_bug.cgi?id=69986

Attachment 111827: Another attempt
https://bugs.webkit.org/attachment.cgi?id=111827&action=review

------- Additional Comments from Nikita Vasilyev <me at elv1s.ru>
(In reply to comment #6)
> > Source/WebCore/inspector/front-end/SettingsScreen.js:53
> > +	 p = this._appendSection(WebInspector.UIString("Editing"));
> 
> Please add all new UIStrings to
Source/WebCore/English.lproj/localizedStrings.js.

Done.

(In reply to comment #8)
> (From update of attachment 111511 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=111511&action=review
> 
> >> Source/WebCore/inspector/front-end/Settings.js:84
> >> +	  this.indent = this.createSetting("indent", "	  ");
> > 
> > defaultIndent?
> 
> You should create this setting from within the TextEditorModel.

Done.

I'll fix all the other staff you've mentioned in
https://bugs.webkit.org/show_bug.cgi?id=70406