[webkit-reviews] review granted: [Bug 63683] Teach new-run-webkit-tests about #CRASHED and #CRASHED - WebProcess : [Attachment 111688] Remove unrelated chnage

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 63683: Teach new-run-webkit-tests about #CRASHED and #CRASHED - WebProcess
https://bugs.webkit.org/show_bug.cgi?id=63683

Attachment 111688: Remove unrelated chnage
https://bugs.webkit.org/attachment.cgi?id=111688&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111688&action=review


> Tools/Scripts/webkitpy/common/net/layouttestresults.py:93
> -	       return [test_failures.FailureCrash()]
> +	       return [test_failures.FailureCrash(process_name="WebProcess")]

This isn't really right, but the right way to fix this is to use the JSON
representation throughout the system.

> Tools/Scripts/webkitpy/layout_tests/port/driver.py:44
> +    def __init__(self, text, image, image_hash, audio,
> +	   crash=False, test_time=0, timeout=False, error='',
> +	   crashed_process_name=None):

This intent is confusing.

> Tools/Scripts/webkitpy/layout_tests/port/webkit.py:477
> +	   elif error_line == "#CRASHED - WebProcess\n":

What about the plugin process?