[webkit-reviews] review denied: [Bug 70440] [Chromium] Export missing symbols from Web*Layer : [Attachment 111673] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Antoine Labour
<piman at chromium.org>'s request for review:
Bug 70440: [Chromium] Export missing symbols from Web*Layer
https://bugs.webkit.org/show_bug.cgi?id=70440

Attachment 111673: Patch
https://bugs.webkit.org/attachment.cgi?id=111673&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111673&action=review


> Source/WebKit/chromium/public/WebContentLayer.h:38
> +class WEBKIT_EXPORT WebContentLayer : public WebLayer {

we don't normally export entire classes.  see other header files.  we just
export the non-inline methods (ignore pure virtual methods of course).