[webkit-reviews] review denied: [Bug 70441] [chromium] Fix webkit style for a few files : [Attachment 111675] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 19 15:49:30 PDT 2011


James Robinson <jamesr at chromium.org> has denied Shawn Singh
<shawnsingh at chromium.org>'s request for review:
Bug 70441: [chromium] Fix webkit style for a few files
https://bugs.webkit.org/show_bug.cgi?id=70441

Attachment 111675: Patch
https://bugs.webkit.org/attachment.cgi?id=111675&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111675&action=review


Thanks for fixing these. The stylebot is correct, though, that the ChangeLog
entry needs a bug number.  Will R+ soon as that's addressed.

> Source/WebCore/platform/graphics/chromium/LayerChromium.cpp:42
> +#include "GraphicsContext3D.h"

I guess this wasn't sorted correctly?

Now that you're moving it, though, do we need it at all in LayerChromium.cpp? I
think the answer is that we don't now that drawTexturedQuad is no longer in
LayerChromium. Can you try deleting it?


More information about the webkit-reviews mailing list