[webkit-reviews] review granted: [Bug 70276] Remove OptionElement (first half) : [Attachment 111657] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 19 15:47:20 PDT 2011


Kent Tamura <tkent at chromium.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 70276: Remove OptionElement (first half)
https://bugs.webkit.org/show_bug.cgi?id=70276

Attachment 111657: Patch
https://bugs.webkit.org/attachment.cgi?id=111657&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111657&action=review


> Source/WebKit/chromium/src/WebOptionElement.cpp:72
> -    return unwrap<HTMLOptionElement>()->setDefaultSelected(newSelected);
> +    return unwrap<HTMLOptionElement>()->setAttribute(selectedAttr,
newSelected ? "" : 0);

Probably we can use setBooleanAttribute().


More information about the webkit-reviews mailing list