[webkit-reviews] review granted: [Bug 69486] watchlist: Should be more robust to bad regex. : [Attachment 111556] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted David Levin <levin at chromium.org>'s
request for review:
Bug 69486: watchlist: Should be more robust to bad regex.
https://bugs.webkit.org/show_bug.cgi?id=69486

Attachment 111556: Patch
https://bugs.webkit.org/attachment.cgi?id=111556&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111556&action=review


> Tools/Scripts/webkitpy/common/watchlist/amountchangedpattern.py:32
> +    def __init__(self, compile_regex, index_for_zero_value):
> +	   self._regex = compile_regex

compile_regex => compiled_regex ?

> Tools/Scripts/webkitpy/common/watchlist/changedlinepattern.py:32
> +    def __init__(self, compile_regex, index_for_zero_value):
> +	   self._regex = compile_regex

Same question.

> Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py:114
> +		   except Exception, e:

Can we catch a more specific exception here?  I bet there's a specific
exception for regexes failing to compile.