[webkit-reviews] review denied: [Bug 69993] CSS2 overflow: scrollbar not visible on SELECT elements when overflow: scroll is set : [Attachment 111567] Updated patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Antaryami Pandia
<xqb748 at motorola.com>'s request for review:
Bug 69993: CSS2 overflow: scrollbar not visible on SELECT elements when
overflow: scroll is set
https://bugs.webkit.org/show_bug.cgi?id=69993

Attachment 111567: Updated patch
https://bugs.webkit.org/attachment.cgi?id=111567&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111567&action=review


>
LayoutTests/fast/css/getComputedStyle/computed-style-select-overflow-expected.t
xt:6
> +PASS computedOverflowStyle('scroll', 'overflow-x') is 'visible'
> +PASS computedOverflowStyle('scroll', 'overflow-y') is 'visible'
> +PASS computedInheritedOverflowStyle('inherit', 'overflow-x') is 'visible'
> +PASS computedInheritedOverflowStyle('inherit', 'overflow-y') is 'visible'

Firefox 7.0.1 says FAIL on these tests for me, matching current WebKit.

FAIL computedOverflowStyle('scroll', 'overflow-x') should be visible. Was
scroll.
FAIL computedOverflowStyle('scroll', 'overflow-y') should be visible. Was
scroll.
FAIL computedInheritedOverflowStyle('inherit', 'overflow-x') should be visible.
Was scroll.
FAIL computedInheritedOverflowStyle('inherit', 'overflow-y') should be visible.
Was scroll.

Consequently, I do not think that this is the right way to approach this
problem.