[webkit-reviews] review denied: [Bug 70234] Web Inspector: make profiler front-end model closure compile. : [Attachment 111273] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 70234: Web Inspector: make profiler front-end model closure compile.
https://bugs.webkit.org/show_bug.cgi?id=70234

Attachment 111273: Patch
https://bugs.webkit.org/attachment.cgi?id=111273&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111273&action=review


> Source/WebCore/inspector/Inspector.json:1962
> +		   "id": "NodeLayoutInfo",

NodeLayoutInfo -> NodeMemoryLayoutInfo or something like that as layout is
generally used in a different sense in WebCore.

> Source/WebCore/inspector/front-end/HeapSnapshotProxy.js:108
> +    this._worker = window.InspectorTest ? new
WebInspector.HeapSnapshotRealWorker() : new
WebInspector.HeapSnapshotFakeWorker();

The if branches are confused, r- for this.