[webkit-reviews] review denied: [Bug 70325] Web Inspector: CSS background-image applied inline shows a warning, but still works. : [Attachment 111592] [PATCH] Added a couple of required drive-by style fixes

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 70325: Web Inspector: CSS background-image applied inline shows a warning,
but still works.
https://bugs.webkit.org/show_bug.cgi?id=70325

Attachment 111592: [PATCH] Added a couple of required drive-by style fixes
https://bugs.webkit.org/attachment.cgi?id=111592&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111592&action=review


> Source/WebCore/css/CSSParser.cpp:557
> +    if (!m_styleSheet)

Please do not mix semantics changes with the lint fixes.

> Source/WebCore/css/CSSParser.h:259
> +    void setStyleSheet(CSSStyleSheet*);

I would add CSSStyleSheet* contextStyleSheet parameter into the
parseDeclaration and make existing call sites (~3 of them) explicitly pass
either parent stylesheet or 0 there.