[webkit-reviews] review granted: [Bug 59863] Incomplete repaint with box-shadow and padding when Javascript updates document : [Attachment 95339] Patch without text in the test

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andrei Bucur <abucur at adobe.com>'s
request for review:
Bug 59863: Incomplete repaint with box-shadow and padding when Javascript
updates document
https://bugs.webkit.org/show_bug.cgi?id=59863

Attachment 95339: Patch without text in the test
https://bugs.webkit.org/attachment.cgi?id=95339&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=95339&action=review

> Source/WebCore/rendering/RenderObject.cpp:1300
> +    // insetShadowTop and insetShadowLeft are not used because the box
didn't change its location

Needs a period.

Confusing comment because it describes the code below, not this code. I think
instead of "are not used" you could say "will not be used below".

Or you could leave the comment out entirely.

> Source/WebCore/rendering/style/RenderStyle.h:1337
> +    void getShadowInsetExtent(const ShadowData*, int &top, int &right, int
&bottom, int &left) const;

Same formatting problem. Notice the mismatch with the next line of code.