[webkit-reviews] review granted: [Bug 70082] implement flex-flow:column : [Attachment 111097] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 70082: implement flex-flow:column
https://bugs.webkit.org/show_bug.cgi?id=70082

Attachment 111097: Patch
https://bugs.webkit.org/attachment.cgi?id=111097&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
I'll r+, but I'm confused as to who sets the logical height of a flexbox.
Normal layout algorithm is:

(1) Compute your logical width
(2) Reset your height to just your borderBefore+paddingBefore
(3) Places your kids, increasing your logical height as you go
(4) When done, you have an intrinsic logical height
(5) Now call computeLogicalHeight to see if you have to shrink

Maybe flexbox will be different, but the above is a bit more like how blocks
and tables work at least. I'm guessing flexboxes with unspecified heights just
aren't working at the moment?