[webkit-reviews] review granted: [Bug 69055] Check behavior of border attribute with a large number : [Attachment 109448] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 16 05:43:32 PDT 2011


Daniel Bates <dbates at webkit.org> has granted Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 69055: Check behavior of border attribute with a large number
https://bugs.webkit.org/show_bug.cgi?id=69055

Attachment 109448: Patch
https://bugs.webkit.org/attachment.cgi?id=109448&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109448&action=review


>
LayoutTests/fast/dom/HTMLImageElement/image-with-invalid-border-expected.html:3

> +<p>Img elements with invalid border attribute should have the same
appearnace with an img element without border attribute.</p>

appearnace => appearance

"with an" => "as an"

> LayoutTests/fast/dom/HTMLImageElement/image-with-invalid-border.html:3
> +<p>Img elements with invalid border attribute should have the same
appearnace with an img element without border attribute.</p>

Ditto.

> LayoutTests/fast/dom/HTMLImageElement/image-with-invalid-border.html:5
> +<img src="resources/blue_rect.jpg" border=invalid>
> +<img src="resources/blue_rect.jpg" border=9999999999>

Nit: This is OK as-is. For your consideration, I suggest putting quotes around
the attribute value for border so to be consistent with the quoting of the
attribute value src. Throughout this patch there is an inconsistent quoting
style for attribute values. I suggest choosing a style for consistency.

>
LayoutTests/fast/dom/HTMLInputElement/input-with-invalid-border-expected.html:3

> +<p>Image input elements with invalid border attribute should have the same
appearnace with an image input element without border attribute.</p>

Ditto.

> LayoutTests/fast/dom/HTMLInputElement/input-with-invalid-border.html:3
> +<p>Image input elements with invalid border attribute should have the same
appearnace with an image input element without border attribute.</p>

Ditto.

>
LayoutTests/fast/dom/HTMLObjectElement/object-with-invalid-border-expected.html
:3
> +<p>Object elements with invalid border attribute should have the same
appearnace with an object element without border attribute.</p>

Ditto.

> LayoutTests/fast/dom/HTMLObjectElement/object-with-invalid-border.html:3
> +<p>Object elements with invalid border attribute should have the same
appearnace with an object element without border attribute.</p>

Ditto.


More information about the webkit-reviews mailing list