[webkit-reviews] review denied: [Bug 70084] Add WebAcceleratedContentLayer backed by a texture to support accelerated content hosting : [Attachment 110948] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Antoine Labour
<piman at chromium.org>'s request for review:
Bug 70084: Add WebAcceleratedContentLayer backed by a texture to support
accelerated content hosting
https://bugs.webkit.org/show_bug.cgi?id=70084

Attachment 110948: Patch
https://bugs.webkit.org/attachment.cgi?id=110948&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110948&action=review


> Source/WebKit/chromium/public/WebAcceleratedContentLayer.h:36
> +class WebAcceleratedContentLayer : public WebLayer {

isn't WebContentLayer accelerated too?	i'm not sure i understand what the
accelerated prefix means here.

perhaps WebExternalContentLayer would be a better name?  it seems like this
is intended to provide the embedder with a way to define a layer from a
given textureId.

perhaps it is obvious to everyone else, but could you explain what setFlip
and flip() are?  it looks like it is a property, but "flip" seems like a
verb to me, and yet you are using it like it is a thing.