[webkit-reviews] review granted: [Bug 70076] [chromium] Make it possible for plugins to get current fullscreen element. : [Attachment 110939] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 13 21:51:13 PDT 2011
Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted
polina at chromium.org's request for review:
Bug 70076: [chromium] Make it possible for plugins to get current fullscreen
element.
https://bugs.webkit.org/show_bug.cgi?id=70076
Attachment 110939: Patch
https://bugs.webkit.org/attachment.cgi?id=110939&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110939&action=review
thanks for fixing those style issues!
> Source/WebKit/chromium/public/WebDocument.h:102
> + WEBKIT_EXPORT WebElement fullScreenElement();
nit: like the other getters, this should be a 'const' method.
> Source/WebKit/chromium/src/WebDocument.cpp:197
> + return WebElement(fullScreenElement);
nit: should be indented by 4 spaces
More information about the webkit-reviews
mailing list