[webkit-reviews] review granted: [Bug 68462] Update PeerConnection to use WebCore platform interfaces : [Attachment 110603] Patch 5

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Adam Bergkvist
<adam.bergkvist at ericsson.com>'s request for review:
Bug 68462: Update PeerConnection to use WebCore platform interfaces
https://bugs.webkit.org/show_bug.cgi?id=68462

Attachment 110603: Patch 5
https://bugs.webkit.org/attachment.cgi?id=110603&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110603&action=review


> Source/WebCore/p2p/PeerConnection.cpp:39
> -PassRefPtr<PeerConnection>
PeerConnection::create(MediaStreamFrameController* frameController, int id,
const String& configuration, PassRefPtr<SignalingCallback> signalingCallback)
> +PassRefPtr<PeerConnection> PeerConnection::create(const String&
serverConfiguration, PassRefPtr<SignalingCallback> signalingCallback,
ScriptExecutionContext* context)

I think the patch to move this to the front has landed.  We need to check that
this compiles when landing.

> Source/WebCore/p2p/PeerConnection.cpp:169
> +    MediaStreamDescriptor* streamDescriptor = 0;
> +    size_t i = m_pendingAddStreams.find(streamDescriptor);
> +    if (i != notFound) {
> +	   m_pendingAddStreams.remove(i);
>	   return;
> +    }
> +
> +    m_pendingRemoveStreams.append(streamDescriptor);
> +    if (m_iceStarted)
> +	   ensureStreamChangeScheduled();

This code appears duplicated.  Maybe break out into a helper function?