[webkit-reviews] review granted: [Bug 68099] [V8] Null v8::Context crash in V8DOMWindowShell::namedItemAdded() : [Attachment 110413] Fix my mistakes in CodeGeneratorV8.pm

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 68099: [V8] Null v8::Context crash in V8DOMWindowShell::namedItemAdded()
https://bugs.webkit.org/show_bug.cgi?id=68099

Attachment 110413: Fix my mistakes in CodeGeneratorV8.pm
https://bugs.webkit.org/attachment.cgi?id=110413&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110413&action=review


> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2711
> -	       if (proxy->windowShell()->initContextIfNeeded()) {
> +	       if (proxy->windowShell()->context().IsEmpty() &&
proxy->windowShell()->initContextIfNeeded()) {

Do you need to run-bindings-tests?